Why is this not working

From: Johnny <kdankwah_at_aol.com>
Date: 26 Oct 2002 11:21:27 -0700
Message-ID: <732d872a.0210261021.5988b063@posting.google.com>

I am trying to do an insert into a table called time. Could someone please tell me if this will do an insert. Also how will I do the execute on this procedure. The arguments are startdate and enddate. Help.

CREATE OR REPLACE PROCEDURE TIME_PROC
( startdate DATE :='01011996',
enddate DATE :='12311998')
AS

   incdate DATE;
   recno INTEGER;
BEGIN
   incdate := startdate;
   recno := 1;
   WHILE incdate <= enddate LOOP

      INSERT INTO time
          (Time_key,
          Year_key,
          Year_id,
          Year_desc,
          Quarter_key,
          Quarter_id,
          Quarter_desc,
         Month_key,
         Month_id,
         Month_desc,
          Date_id,
          Date_desc)
    VALUES( recno,
            recno,
          TO_NUMBER( TO_DATE( incdate, 'YYYY'  ) ),
            TO_NUMBER( TO_DATE( incdate, 'YYYY' ) ),
            TO_NUMBER( TO_DATE( incdate, 'Q1'  ) ),
            TO_NUMBER( TO_DATE( incdate, 'Q1'||'-'||'YYYY'  ) ),
            TO_NUMBER(TO_DATE( incdate, 'Q1'||'-'||'YYYY'  ) ),
       TO_NUMBER( TO_DATE( incdate, 'MM' ) ),
            TO_NUMBER( TO_DATE( incdate, 'MM'||'-'||'YY' ) ),
    TO_NUMBER( TO_DATE( incdate, 'MM'||'-'||'YY' ) ),
       TO_DATE( incdate, 'MMDDYYYY' ) ,
            TO_DATE( incdate, 'MMDDYYYY'  ) );
          recno   := recno   + 1;
          incdate := incdate + 1;
      END LOOP;
      COMMIT;

END time_proc;
/

Execute time_proc TO_DATE(01012002,09302002)

/

Its not doing the insert.

Thanks, Received on Sat Oct 26 2002 - 13:21:27 CDT