Re: hi all

"mamta81" <roy.mamta_at_gmail.com> a écrit dans le message de news: 1194856541.430671.148720_at_i38g2000prf.googlegroups.com...
| Hi , I have a file cfoil1.sql when i try to run tht in my sqldeveloper
| or toad i get the following error message
|
| declare
| CURSOR l1 is select bank_code,x,name,cat,idcode
| from salchq order by cat,bank_code,idcode;
| chq_no number(6):= 190423;
| bnk_code char(2);
| netsal number;
| bnkname varchar2 (120);
| cat char(1);
| idcode char(6);
| begin
| OPEN l1;
| LOOP
| FETCH l1 into bnk_code, netsal,bnkname,cat,idcode;
| EXIT when l1%notfound;
| chq_no := chq_no + 1;
| if bnk_code != 'AZ' then
| insert into C_FOIL (CHQ_NO,BNKCODE,BNKNAME,NETSAL,CAT,IDCODE)
| values (chq_no,bnk_code,bnkname,netsal,cat,idcode);
| commit;
| END IF;
| END LOOP;
| close l1;
| end;
| insert into sal_chq_printed select mon_start, chq_no, bnkcode,
| bnkname, netsal, idcode from c_foil, s_globals
|
| /
|

Good example of bad pratice!

The whole PL/SQL block is no more than:

insert into C_FOIL (CHQ_NO,BNKCODE,BNKNAME,NETSAL,CAT,IDCODE) select chq_no+rownum-1, bank_code,x,name,cat,idcode from salchq
where bnk_code != 'AZ'
order by cat,bank_code,idcode;

Regards
Michel Cadot Received on Mon Nov 12 2007 - 10:30:12 CST