Re: Need Help with some PLSQL code please

Comments interspersed:

Chris ( Val ) wrote:

>"Daniel Morgan" <damorgan_at_x.washington.edu> wrote in message
>news:1063469307.155833_at_yasure...
>| Comments interspersed:
>|
>| Chris ( Val ) wrote:
>|
>| ><snipped>
>
>Hi Daniel.
>
>| I would suggest you rewrite in the following form:
>|
>| CREATE OR REPLACE PROCEDURE FIND_DXF_ERRORS (....) IS
>|
>| CURSOR and EXCEPTION definitions ...
>|
>| MyFlag BOOLEAN := FALSE;
>| Counter NUMBER( 5 ) := 0;
>|
>| TempID VARCHAR2( 50 );
>| nTempID NUMBER(##);
>
>I haven't come across this yet.
>Is the meaning of '##' to take two variant like characters ?
>

It was intended to convey that I have no idea what integer value belongs in there. Fill it in based on the table or, better yet, use table_name.column_name%TYPE.

>| TempDate VARCHAR2( 50 );
>| dTempDate DATE;
>|
>| BEGIN
>| BEGIN
>| nTempID := TO_NUMBER(TempID);
>| EXCEPTION
>| WHEN OTHERS THEN
>| RAISE ...
>| END;
>|
>| BEGIN
>| dTempDate := TO_DATE(TempDate);
>| EXCEPTION
>| WHEN OTHERS THEN
>| RAISE ...
>| END;
>|
>| ....
>|
>| END;
>| /
>|
>| Dump the functions and just deal directly with the problem at hand.
>
>I had something similar to this originally, but I guess I got carried
>away. Thanks for your suggestion also, much appreciated.
>
>Cheers.
>Chris Val
>
>
>

You're welcome.

-- 
Daniel Morgan
http://www.outreach.washington.edu/ext/certificates/oad/oad_crs.asp
http://www.outreach.washington.edu/ext/certificates/aoa/aoa_crs.asp
damorgan_at_x.washington.edu
(replace 'x' with a 'u' to reply)