| Oracle FAQ | Your Portal to the Oracle Knowledge Grid | |
 |
 | |||
| Oracle FAQ | Your Portal to the Oracle Knowledge Grid | |
|
| |||
Home -> Community -> Mailing Lists -> Oracle-L -> RE: PL/SQL coding style
This is a multi-part message in MIME format.
------=_NextPart_000_006E_01C08160.CC22CC50 Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
RE: PL/SQL coding styleLisa,
When you say " Give him Feuernstein's book. " what book do you mean? I
can't seem to find a book by such an author on my usual search engine.
Amazon gives me '1354 total matches for "bernstein" ' when I do a search on
'Feuernstein'
David
-----Original Message-----
From: root_at_fatcity.com [mailto:root_at_fatcity.com]On Behalf Of Koivu, Lisa
Sent: Thursday, January 18, 2001 10:17 AM
To: Multiple recipients of list ORACLE-L
Subject: RE: PL/SQL coding style
Chandini,
GOTOS are ABSOLUTE VOODOO. He thinks that SELECT INTO is more readable, how readable is a GOTO?? It ISN'T. Good style also involves writing code that does not involve UNNECESSARY PROCESSING.
Give him Feuernstein's book. That's correct style in my opinion that is not recreating the wheel and utilizing all that PL/SQL does for you.
I almost liken not using exception handling to not using the classes that are given to you in java.
But seriously, I've been in the same position. Being the dba, all code that is compiled into the database is my responsibility. When I came here, I screamed bloody murder because exceptions weren't being used, the sqlcode was being passed all over the place instead. I insisted on changes to the standards document to enforce use of exceptions plus educated some of the developers on how to use them. The bottom line is, if you support it, then you give the final yay or nay for the code.
Of course, you could be direct and just tell him to pull his head out.
HTH
Lisa
-----Original Message-----
From: Chandini Paterson [mailto:chandini.paterson_at_morse.com]
Sent: Thursday, January 18, 2001 11:02 AM
To: Multiple recipients of list ORACLE-L
Subject: PL/SQL coding style
Hi gurus,
I've just changed jobs quite recently and am already having problems with
my Senior Developer (yippee)
It concerns the PL/SQL coding style. The guy insists that I use 'SELECT
..INTO ' in my code rather than explicit cursors, even though I tried
telling him it is more efficient with the latter. He apparently finds it
more 'readable' with the 'SELECT.. INTO ' and says that the double fetch
(for each row) is 'no big deal'.
Also, he insists of using a lot of GOTOs in his code and expects me to do
the same. I am adamant that we use EXCEPTION handlers to achieve the same
thing (BAsically he checks for error conditions in his code and then does a
'goto error_handler' to handle the error!!!). I prefer using EXCEPTIONS to
handle all my error conditions.
I was just wondering if my concepts are all wrong at this time. I am just
curious to know if any of you find his way of coding style preferable to
mine. (OH, by the way, he was initially a 'C' progrmmer). Any inputs will
be greatly appreciated.
Thanks
Chandini
-- Please see the official ORACLE-L FAQ: http://www.orafaq.com -- Author: Chandini Paterson INET: chandini.paterson_at_morse.com Fat City Network Services -- (858) 538-5051 FAX: (858) 538-5051 San Diego, California -- Public Internet access / Mailing Lists -------------------------------------------------------------------- To REMOVE yourself from this mailing list, send an E-Mail message to: ListGuru_at_fatcity.com (note EXACT spelling of 'ListGuru') and in the message BODY, include a line containing: UNSUB ORACLE-L (or the name of mailing list you want to be removed from). You may also send the HELP command for other information (like subscribing). ------=_NextPart_000_006E_01C08160.CC22CC50 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML><HEAD><TITLE>RE: PL/SQL coding style</TITLE> <META content=3D"text/html; charset=3Diso-8859-1" = http-equiv=3DContent-Type> <META content=3D"MSHTML 5.00.3103.1000" name=3DGENERATOR></HEAD> <BODY bgColor=3D#c0c0c0> <DIV><FONT color=3D#0000ff face=3DArial size=3D2><SPAN=20 class=3D504350422-18012001>Lisa,</SPAN></FONT></DIV> <DIV><FONT color=3D#0000ff><SPAN=20 class=3D504350422-18012001></SPAN></FONT> </DIV> <DIV><FONT color=3D#0000ff><FONT size=3D2><FONT face=3DArial><SPAN=20 class=3D504350422-18012001>When you say "</SPAN><SPAN=20 class=3D504350422-18012001> </SPAN>Give him Feuernstein's = book. <SPAN=20 class=3D504350422-18012001>" what book do you mean? I = can't seem=20 to find a book by such an author on my usual search engine. Amazon = gives=20 me '1354 total matches for "bernstein" ' when I do a search on=20Received on Thu Jan 18 2001 - 16:10:30 CST
'Feuernstein'</SPAN></FONT></FONT></FONT></DIV>
<DIV> </DIV> <DIV><FONT color=3D#0000ff face=3DArial size=3D2><SPAN=20 class=3D504350422-18012001>David</SPAN></FONT></DIV> <DIV> </DIV> <DIV align=3Dleft class=3DOutlookMessageHeader dir=3Dltr><FONT = face=3DTahoma=20 size=3D2>-----Original Message-----<BR><B>From:</B> root_at_fatcity.com=20 [mailto:root_at_fatcity.com]<B>On Behalf Of </B>Koivu, Lisa<BR><B>Sent:</B> = Thursday, January 18, 2001 10:17 AM<BR><B>To:</B> Multiple recipients of = list=20 ORACLE-L<BR><B>Subject:</B> RE: PL/SQL coding style<BR><BR></FONT></DIV> <P><FONT size=3D2>Chandini, </FONT></P> <P><FONT size=3D2>GOTOS are ABSOLUTE VOODOO. He thinks that SELECT = INTO is=20 more readable, how readable is a GOTO?? It ISN'T. Good style = also=20 involves writing code that does not involve UNNECESSARY = PROCESSING. =20 </FONT></P> <P><FONT size=3D2>Give him Feuernstein's book. That's correct = style in my=20 opinion that is not recreating the wheel and utilizing all that PL/SQL = does for=20 you. </FONT></P> <P><FONT size=3D2>I almost liken not using exception handling to not = using the=20 classes that are given to you in java. </FONT></P> <P><FONT size=3D2>But seriously, I've been in the same position. = Being the=20 dba, all code that is compiled into the database is my = responsibility. =20 When I came here, I screamed bloody murder because exceptions weren't = being=20 used, the sqlcode was being passed all over the place instead. I = insisted=20 on changes to the standards document to enforce use of exceptions plus = educated=20 some of the developers on how to use them. The bottom line is, if = you=20 support it, then you give the final yay or nay for the code. = </FONT></P> <P><FONT size=3D2>Of course, you could be direct and just tell him to = pull his=20 head out. </FONT></P> <P><FONT size=3D2>HTH</FONT> <BR><FONT size=3D2>Lisa</FONT> </P> <P><FONT size=3D2>-----Original Message-----</FONT> <BR><FONT = size=3D2>From:=20 Chandini Paterson [<A=20 href=3D"mailto:chandini.paterson_at_morse.com">mailto:chandini.paterson_at_mors= e.com</A>]</FONT>=20 <BR><FONT size=3D2>Sent: Thursday, January 18, 2001 11:02 AM</FONT> = <BR><FONT=20 size=3D2>To: Multiple recipients of list ORACLE-L</FONT> <BR><FONT = size=3D2>Subject:=20 PL/SQL coding style</FONT> </P><BR> <P><FONT size=3D2>Hi gurus,</FONT> <BR><FONT size=3D2> I've just = changed jobs=20 quite recently and am already having problems with</FONT> <BR><FONT = size=3D2>my=20 Senior Developer (yippee)</FONT> <BR><FONT size=3D2> It concerns = the PL/SQL=20 coding style. The guy insists that I use 'SELECT</FONT> <BR><FONT=20 size=3D2>..INTO ' in my code rather than explicit cursors, even though I = tried</FONT> <BR><FONT size=3D2>telling him it is more efficient with = the latter.=20 He apparently finds it</FONT> <BR><FONT size=3D2>more 'readable' with = the=20
'SELECT.. INTO ' and says that the double fetch</FONT> <BR><FONT =
size=3D2>(for=20 each row) is 'no big deal'.</FONT> <BR><FONT size=3D2> Also, he = insists of=20 using a lot of GOTOs in his code and expects me to do</FONT> <BR><FONT=20 size=3D2>the same. I am adamant that we use EXCEPTION handlers to = achieve=20 the same</FONT> <BR><FONT size=3D2>thing (BAsically he checks for error = conditions=20 in his code and then does a</FONT> <BR><FONT size=3D2>'goto = error_handler' to=20 handle the error!!!). I prefer using EXCEPTIONS to</FONT> <BR><FONT=20 size=3D2>handle all my error conditions.</FONT> <BR><FONT = size=3D2> I was just=20 wondering if my concepts are all wrong at this time. I am = just</FONT>=20 <BR><FONT size=3D2>curious to know if any of you find his way of coding = style=20 preferable to</FONT> <BR><FONT size=3D2>mine. (OH, by the way, he was = initially a=20
'C' progrmmer). Any inputs will</FONT> <BR><FONT size=3D2>be =
greatly=20 appreciated.</FONT> </P> <P><FONT size=3D2>Thanks</FONT> <BR><FONT size=3D2>Chandini</FONT> </P> <P><FONT size=3D2>-- </FONT><BR><FONT size=3D2>Please see the official = ORACLE-L FAQ:=20 <A href=3D"http://www.orafaq.com" = target=3D_blank>http://www.orafaq.com</A></FONT>=20 <BR><FONT size=3D2>-- </FONT><BR><FONT size=3D2>Author: Chandini = Paterson</FONT>=20 <BR><FONT size=3D2> INET: chandini.paterson_at_morse.com</FONT> </P> <P><FONT size=3D2>Fat City Network Services -- (858)=20 538-5051 FAX: (858) 538-5051</FONT> <BR><FONT size=3D2>San Diego,=20 California -- Public Internet = access /=20 Mailing Lists</FONT> <BR><FONT=20 size=3D2>----------------------------------------------------------------= ----</FONT>=20 <BR><FONT size=3D2>To REMOVE yourself from this mailing list, send an = E-Mail=20 message</FONT> <BR><FONT size=3D2>to: ListGuru_at_fatcity.com (note EXACT = spelling of=20
'ListGuru') and in</FONT> <BR><FONT size=3D2>the message BODY, include a =
line=20 containing: UNSUB ORACLE-L</FONT> <BR><FONT size=3D2>(or the name of = mailing list=20
 |
 |